-
Notifications
You must be signed in to change notification settings - Fork 115
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove "no-samples" for Fujifilm FinePix S9600fd #731
Remove "no-samples" for Fujifilm FinePix S9600fd #731
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
First, if that is a standalone camera entry, it must have samples.
Second, clearly we aren't bothering them enough since there's still no RPU sample for S9600fd in review queue. /s
Thirdly, if this is the exact same camera, it's whole <Camera>
should be
<Aliases>
<Alias id="FinePix S9600fd">Fujifilm FinePix S9600fd</Alias>
</Aliases>
in <Camera>
for S9600
. I think that will also silence that begging too.
06eefd9
to
6ff389a
Compare
This camera is almost two decades old, so we shouldn't expect many darktable users to process images from this camera. And this makes it very unlikely that we will ever see samples from this particular camera model. :(
I agree. The xml entries for these two cameras are identical, so the replacement to Alias was a natural choice. I simply chose the fix that made the least change to the current data. Changed. |
@victoryforce thank you! |
<Crop x="64" y="0" width="-64" height="0"/> | ||
<Sensor black="0" white="15872"/> | ||
<Aliases> | ||
<Alias id="FinePix S9600fd">Fujifilm FinePix S9600fd</Alias> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is wrong and won't work - should just say <Alias>FinePix S9600fd</Alias>
(i.e., the actual value and the id
attribute should be identical in this case, so the attribute can be omitted).
Please fix before merging to stable and uploading to dt submodule. @victoryforce @LebedevRI
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, drat! I just copy-pasted the suggested string, although I could have noticed that a little higher in the file there is Alias written differently... :( Thanks for noticing!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, as i've said previously, i don't fully understand/remember this <Alias>
syntax.
I thought that is what the right line is, based on what happens for Canon entries.
@kmilos thanks!
S9600fd is just S9600 with face detection (and for S9600 we have a sample in RPU). In the Fujifilm model line, there were several cases of models being released without and with the
fd
suffix. Such models are identical in everything else except for the presence of face detection code in the camera firmware.So we can avoid annoying the user with "no-samples" warnings for S9600fd.