Add dependencies present in requirements.txt to setup.py #102
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
NVM, It breaks the install. |
|
Defering to post eval since it is not critical. |
Pikus16
approved these changes
May 12, 2021
|
Closing since we are transitioning to poetry. Thus this is not relevant. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the dependencies present in requirements.txt back in setup.py. Originally this was removed because requirements.txt had absolute requirements rather than absolute requirements. This was changed in #85, thus we can add dependencies present in requirements.txt back into setup.py without running into version conflicts. Closes #28 since a warning isn't required anymore.