Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tall style: Don't expand (single-element?) lists to multiline if you don't have to #1533

Closed
nex3 opened this issue Aug 16, 2024 · 1 comment · Fixed by #1549
Closed

Tall style: Don't expand (single-element?) lists to multiline if you don't have to #1533

nex3 opened this issue Aug 16, 2024 · 1 comment · Fixed by #1549

Comments

@nex3
Copy link
Member

nex3 commented Aug 16, 2024

I dislike the fact that the single-element list is expanded here:

void main() {
  ComplexSelector(complex.leadingCombinators, [
    component,
  ], complex.span, lineBreak: false);
}

I'd prefer this:

void main() {
  ComplexSelector(
    complex.leadingCombinators,
    [component],
    complex.span,
    lineBreak: false
  );
}

I think generally I'd prefer the latter style until the list is too long to fit on one line, but I can swallow the former more easily as long as the list has more than one element.

@dcharkes
Copy link

Might be related to:

munificent added a commit that referenced this issue Aug 28, 2024
This was fixed by #1548.

Fix #1533.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants