set tcpNoDelay option on all sockets for 100x speedup

dart-lang · Oct 18, 2024 · 506fa92 · 506fa92
1 parent a482288
commit 506fa92
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 1 deletion.
diff --git a/pkgs/_macro_client/lib/macro_client.dart b/pkgs/_macro_client/lib/macro_client.dart
@@ -28,6 +28,8 @@ class MacroClient {
   final Map<int, Completer<Response>> _responseCompleters = {};
 
   MacroClient._(this.macros, this.socket) {
+    // Nagle's algorithm slows us down >100x, disable it.
+    socket.setOption(SocketOption.tcpNoDelay, true);
     _host = RemoteMacroHost(this);
     _start();
   }

diff --git a/pkgs/_macro_server/lib/macro_server.dart b/pkgs/_macro_server/lib/macro_server.dart
@@ -121,7 +121,10 @@ class _Connection {
   /// Responses to query requests from the macro.
   Stream<Response> get responses => _responsesController.stream;
 
-  _Connection(this.socket);
+  _Connection(this.socket) {
+    // Nagle's algorithm slows us down >100x, disable it.
+    socket.setOption(SocketOption.tcpNoDelay, true);
+  }
 
   @override
   String toString() => '_Connection($descriptions)';