Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add macro metadata dart_model types and converter. #118

Merged
merged 1 commit into from
Oct 25, 2024

Conversation

davidmorgan
Copy link
Contributor

  • Two generate scripts: generate_definitions which generates dart_model definitions from _fe_analyzer_shared code, and generate_converter which generates code to convert from _fe_analyzer_shared code to the new dart_model types.
    • Neither is intended to be maintained, I'll delete if we don't need them again or rewrite if we need to iterate / use them more than once.
  • Add definitions from generate_definitions to macro_metadata_definitions.dart.
  • Add package _analyzer_cfe_macros for common code between _analyzer_macros and _cfe_macros, this code will likely end up in _fe_analyzer_shared.
  • Add converter from generate_converter to _analyzer_cfe_macros and simple unit test.

@davidmorgan davidmorgan changed the title Add macro metadata converter. Add macro metadata dart_model types and converter. Oct 25, 2024
@davidmorgan davidmorgan force-pushed the convert-macro-metadata branch 4 times, most recently from bbbf0b8 to 6d83652 Compare October 25, 2024 09:29
@davidmorgan davidmorgan marked this pull request as ready for review October 25, 2024 11:57
@davidmorgan davidmorgan merged commit 90d9129 into dart-lang:main Oct 25, 2024
47 checks passed
@davidmorgan davidmorgan deleted the convert-macro-metadata branch October 25, 2024 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants