Skip to content
This repository has been archived by the owner on Feb 4, 2025. It is now read-only.

set up mono_repo configs #12

Merged
merged 6 commits into from
Jun 21, 2024
Merged

set up mono_repo configs #12

merged 6 commits into from
Jun 21, 2024

Conversation

jakemac53
Copy link
Contributor

@jakemac53 jakemac53 commented Jun 21, 2024

Closes #2

I also added tool/dart_model_generator to the workspace config.

@jakemac53 jakemac53 requested a review from davidmorgan June 21, 2024 14:48
@davidmorgan
Copy link
Contributor

Neat, thanks.

dart_model_generator doesn't have any test yet, let me see if I can add a golden test... feel free to merge before, to wait, to add an empty test, or to tweak the config so it doesn't test, as you like :)

@davidmorgan
Copy link
Contributor

#13 :)

@jakemac53
Copy link
Contributor Author

cc @davidmorgan we are somehow getting carriage returns on windows, I just changed it to use equalsIgnoringWhitespace for now, which will only capture meaningful changes... but we could end up swapping between carriage returns and not, if people generate on windows versus other platforms...

@davidmorgan
Copy link
Contributor

Curious, maybe add a TODO / issue somewhere? We probably don't want to accidentally publish with different line endings.

@jakemac53 jakemac53 merged commit 98ae98b into main Jun 21, 2024
13 checks passed
@jakemac53 jakemac53 deleted the add-mono-repo branch June 21, 2024 16:16
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Set up lints, analysis presubmit, test presubmit
2 participants