Differentiate types of request explicitly, remove ListOfService. #27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jakemac53
reviewed
Aug 7, 2024
pkgs/_macro_host/lib/macro_host.dart
Outdated
Comment on lines
31
to
33
| final result = MacroHost._(queryService); | ||
| final server = await MacroServer.serve(service: result); | ||
| result._macroServer = server; |
There was a problem hiding this comment.
This is definitely still sending up red flags for me, assigning manually fields like this after construction is something I would always try to avoid. I get that the cyclic dependency sort of requires it here, but I would still like to see that cycle broken.
There was a problem hiding this comment.
The circle is due to the class doing too much: it's the host and the host service.
Split out the host service and now it looks much better, thanks :)
jakemac53
reviewed
Aug 7, 2024
pkgs/_macro_host/lib/macro_host.dart
Outdated
| return MacroHost._(server, listOfServices); | ||
| /// Starts a macro host with introspection queries handled by [queryService]. | ||
| static Future<MacroHost> serve({required QueryService queryService}) async { | ||
| final result = MacroHost._(queryService); |
There was a problem hiding this comment.
nit: just call this host or something, it isn't really a "result" (there is no query or anything, its just a constructor call).
jakemac53
approved these changes
Aug 7, 2024
davidmorgan
force-pushed
the
remove-list-of-service
branch
from
f5c68da
to
36c62b0
Compare
davidmorgan
force-pushed
the
remove-list-of-service
branch
from
36c62b0
to
e5139f6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.