Support string and null as schema representation #30
Conversation
| }; | ||
|
|
||
| for (final MapEntry(:key, :value) in allDefinitions.entries) { | ||
| if (value.oneOf.isNotEmpty) { |
There was a problem hiding this comment.
I just merged another PR tweaking generation for oneOf, because the schema was not correct, please rebase; sorry about that. It moves the oneOf in the schema into a property called value, since that's what we write on the wire.
| voidType; | ||
| } | ||
|
|
||
| extension type StaticType.fromJson(Map<String, Object?> node) { |
There was a problem hiding this comment.
It would be useful to see schema change + code change + generator together, but I don't see the schema change--could you add it please?
There isn't any other test coverage for the generator besides what is in the schema, so it probably makes sense to add something to the schema even if it's just showing the new functionality. In that case please note in the description that the type is currently just there to show the union functionality :)
There was a problem hiding this comment.
I didn't mean to commit the type changes in this PR, but I've added a few types with their schema definitions to test the generator.
simolus3
force-pushed
the
simpler-schema-types
branch
from
844f185
to
44026b6
Compare
|
Please fix lint violation |
In addition to
"type": "object", it looks like the schema generator partially supports using"type": "string"for definitions. Those definitions are broken in unions though, as the generator for unions expects all definitions to be JSON.This PR fixes that, and also adds support for
"type": "null"definitions. Those are useful as part of unions if we only care about the element type. To model Dart's type hierarchy for instance, we may have anunion StaticType = InterfaceType {...} | NullableType { StaticType inner } | ... | DynamicType. There is nothing interesting aboutDynamicTypeapart from knowing that we're dealing withdynamic, sonullmakes sense as the underlying JSON representation here.