Cache canonicalized version of paths in path dependencies (#4495)

dart-lang · Jan 16, 2025 · 710265b · 710265b
1 parent eaf03b3
commit 710265b
Showing 1 changed file with 5 additions and 2 deletions.
diff --git a/lib/src/source/path.dart b/lib/src/source/path.dart
@@ -270,6 +270,9 @@ class PathDescription extends Description {
   final String path;
   final bool relative;
 
+  // Canonicalization is rather slow - cache the result;
+  late final String _canonicalizedPath = canonicalize(path);
+
   PathDescription(this.path, this.relative) : assert(!p.isRelative(path));
   @override
   String format() {
@@ -294,11 +297,11 @@ class PathDescription extends Description {
   @override
   bool operator ==(Object other) {
     return other is PathDescription &&
-        canonicalize(path) == canonicalize(other.path);
+        _canonicalizedPath == other._canonicalizedPath;
   }
 
   @override
-  int get hashCode => canonicalize(path).hashCode;
+  int get hashCode => _canonicalizedPath.hashCode;
 }
 
 class ResolvedPathDescription extends ResolvedDescription {