Evaluation failing for non-null, nullable field

[kenzieschmoll]

a is a nullable list. At the point of evaluation, a has been checked non null.

We should either

1. have evaluation respect the type promotion that occurs earlier in the method, or
2. have evaluation insert a ! for nullable variable a when evaluating a.length. If a is null, I would expect a null assertion error. If a is non-null, a.length should evaluate as expected (which is the current result of a?.length)

@annagrin

[annagrin]

a.length is compiled by the incremental compiler, wrapped in a synthetic function, an all the scope (such as a) is passed to it as parameters.

We can investigate some solutions here:

• compile the expression in some relaxed way (or assume any access has a !) so it fails at runtime if needed.
• make the incremental compiler collect the type promotion information from the scope and use it in the expression compilation.

/cc @jensjoha @johnniwinther do you think any of those are feasible in the incremental compiler? For the first one, it there a setting I can pass to the incremental compiler (to ignore null safety information but not fail on null-safe syntax either?)

Transferring this to the SDK repo as the changes would need to be done in the frontend server, ddc, and maybe in the incremental compiler.