VmService.getPerfettoVMTimelineWithCpuSamples is slow #55137
Assignees
Labels
area-vm
Use area-vm for VM related issues, including code coverage, and the AOT and JIT backends.
P3
A lower priority bug or feature request
triaged
Issue has been triaged by sub team
vm-service
The VM Service Protocol, both the specification and its implementation
Comments
lrhn
added
the
area-vm
a-siva
added
the
vm-service
a-siva
added
P2
derekxu16
added
P3
|
Reducing the priority to P3, because we expect requesting CPU samples from the VM Service to be slow compared to requesting the timeline. I will try to profile the VM Service code at some point to see if there's are any significant performance improvements we can make. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
I'm working on switching DevTools over to the new Perfetto VM timeline APIs and away from the legacy Chrome trace format APIs: flutter/devtools#4755
I'm seeing some performance concerns with
getPerfettoVMTimelineWithCpuSamples. On average callinggetPerfettoVMTimelineWithCpuSamplestakes 1-2 orders of magnitude more time than callinggetPerfettoVMTimeline. Can we optimize this at all, or is this overhead expected and unavoidable?In the short term, we could have a setting in the DevTools "Enable CPU sampling in the timeline", that is off by default and warns users that this may have performance implications to turn on.
@derekxu16 @bkonyi
The text was updated successfully, but these errors were encountered: