Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate and possibly use reset in the frontend server instead of recompile-restart to signal a hot restart #60010

Open
srujzs opened this issue Jan 30, 2025 · 0 comments
Assignees
Labels
area-web Use area-web for Dart web related issues, including the DDC and dart2js compilers and JS interop. cfe-frontend-server Frontend server issues for the CFE web-dev-compiler

Comments

@srujzs
Copy link
Contributor

srujzs commented Jan 30, 2025

https://dart-review.googlesource.com/c/sdk/+/406200 adds a new instruction to the frontend server to differentiate recompiles that occur during a hot reload and those that occur during a hot restart. This is needed so that DDC can determine whether to throw errors related to a change that cannot be hot reloaded.

During review, a suggestion came up to perhaps use reset before a recompile to signal a hot restart. reset changes the incremental compiler so it outputs a full component. It isn't clear if we can split the full component back to its intended partial component in a way that won't break the JS bundler or DDC.

If we can, then we can reset in Flutter tools and avoid needing a recompile-restart.

@srujzs srujzs added area-web Use area-web for Dart web related issues, including the DDC and dart2js compilers and JS interop. cfe-frontend-server Frontend server issues for the CFE web-dev-compiler labels Jan 30, 2025
@srujzs srujzs self-assigned this Jan 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-web Use area-web for Dart web related issues, including the DDC and dart2js compilers and JS interop. cfe-frontend-server Frontend server issues for the CFE web-dev-compiler
Projects
None yet
Development

No branches or pull requests

1 participant