Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dart format page #6367

Merged
merged 5 commits into from
Jan 30, 2025
Merged

Update dart format page #6367

merged 5 commits into from
Jan 30, 2025

Conversation

MaryaBelanger
Copy link
Contributor

Fixes #6222

@dart-github-bot
Copy link
Collaborator

dart-github-bot commented Jan 27, 2025

Visit the preview URL for this PR (updated for commit e3b33a9):

https://dart-dev--pr6367-update-format-5bvdn0sx.web.app

@@ -66,21 +66,13 @@ so they can trigger another action in response to the exit code.
$ dart format -o none --set-exit-if-changed bin/my_app.dart
```

## Use trailing commas
## Whitespace and commas
Copy link
Contributor Author

@MaryaBelanger MaryaBelanger Jan 27, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@munificent I considered the points you made in the issue and thought this might be a good in between vs. getting rid of the sections all together. Do you think a brief summary about what the format generally changes, like I added here, is useful?

I might also added to this list that format will format the line length too (#6223) so lmk if that makes sense too.

Copy link
Member

@parlough parlough left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks! One fix and an optional consideration :)

src/content/tools/dart-format.md Outdated Show resolved Hide resolved
src/content/tools/dart-format.md Outdated Show resolved Hide resolved
@MaryaBelanger MaryaBelanger merged commit 13422bc into main Jan 30, 2025
9 of 10 checks passed
@MaryaBelanger MaryaBelanger deleted the update-format branch January 30, 2025 17:08
@munificent
Copy link
Member

This looks great! Sorry I didn't see this PR go by.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Changes to /tools/dart-format for new formatter
4 participants