Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing redirects for (all?) guides #6384

Closed
dkbast opened this issue Feb 3, 2025 · 1 comment · Fixed by #6385
Closed

Missing redirects for (all?) guides #6384

dkbast opened this issue Feb 3, 2025 · 1 comment · Fixed by #6385
Assignees
@parlough
Labels
e0-minutes Can complete in < 60 minutes of normal, not dedicated, work from.user Issue raised by user infra.structure Relates to the tools that create dart.dev p0-critical Critical and urgent concern: breaks builds, impacts team velocity. Resolve in weeks. Update weekly.

Comments

@dkbast
Copy link
Contributor

dkbast commented Feb 3, 2025 •
edited
Loading

Describe the problem

The dart guides seem to have gone - when searching for "define" on google.com or dart.dev (looking for the environment variable parameter) I get this link served in the results: https://dart.dev/guides/environment-declarations - unfortunately this leads just to https://dart.dev/docs - it should redirect to https://dart.dev/libraries/core/environment-declarations

This seems to have been missed in #5767 and imho should be addressed (urgently) as the new "home" is not yet indexed and thereby not easily accessible anymore resulting in a degraded user experience (which obviously was not the intention).

Expected fix

All guides which have been "rehomed" should have a 301 redirect to their new homes.

cc @parlough
@dkbast dkbast added from.user Issue raised by user infra.structure Relates to the tools that create dart.dev labels Feb 3, 2025
@dkbast dkbast mentioned this issue Feb 3, 2025
Closed
@MaryaBelanger
Copy link
Contributor

MaryaBelanger commented Feb 3, 2025 •
edited
Loading

Confirmed that following this link from search goes to dart.dev/docs home page

Image

And the same happens (goes to dart.dev/docs) from dart.dev search (tested in staging)

Image

@parlough parlough mentioned this issue Feb 3, 2025
Merged
@parlough parlough added p0-critical Critical and urgent concern: breaks builds, impacts team velocity. Resolve in weeks. Update weekly. e0-minutes Can complete in < 60 minutes of normal, not dedicated, work labels Feb 3, 2025
parlough added a commit that referenced this issue Feb 3, 2025
@parlough
Fix blanket /guides redirect (#6385)
347e239 
Fixes #6384 by moving the blanket redirect to a fallback redirect
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@parlough parlough

Labels
e0-minutes Can complete in < 60 minutes of normal, not dedicated, work from.user Issue raised by user infra.structure Relates to the tools that create dart.dev p0-critical Critical and urgent concern: breaks builds, impacts team velocity. Resolve in weeks. Update weekly.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix blanket /guides redirect dart-lang/site-www
3 participants
@dkbast @parlough @MaryaBelanger