From afd95da0e93039e2d14ae351c0e1ef6df780e207 Mon Sep 17 00:00:00 2001 From: Parker Lougheed Date: Fri, 22 Nov 2024 13:06:49 +0800 Subject: [PATCH] Fix a few diagnostics in anticipation of lints v5 --- dwds/lib/src/debugging/inspector.dart | 3 ++- dwds/lib/src/debugging/metadata/class.dart | 4 ++-- dwds/lib/src/readers/asset_reader.dart | 2 +- dwds/lib/src/services/expression_evaluator.dart | 5 +++-- dwds/test/fixtures/project.dart | 4 ++-- 5 files changed, 10 insertions(+), 8 deletions(-) diff --git a/dwds/lib/src/debugging/inspector.dart b/dwds/lib/src/debugging/inspector.dart index dafd9325e..2d0d882cd 100644 --- a/dwds/lib/src/debugging/inspector.dart +++ b/dwds/lib/src/debugging/inspector.dart @@ -692,7 +692,8 @@ class AppInspector implements AppInspectorInterface { return _instanceHelper.metadataHelper.isNativeJsError(instanceRef.classRef); } - /// Request and cache s for all the scripts in the application. + /// Request and cache `` tags for all the + /// scripts in the application. /// /// This populates [_scriptRefsById], [_scriptIdToLibraryId], /// [_libraryIdToScriptRefs] and [_serverPathToScriptRef]. diff --git a/dwds/lib/src/debugging/metadata/class.dart b/dwds/lib/src/debugging/metadata/class.dart index 17bcbbc45..04a88ca5e 100644 --- a/dwds/lib/src/debugging/metadata/class.dart +++ b/dwds/lib/src/debugging/metadata/class.dart @@ -90,7 +90,7 @@ class ClassMetaData { /// Type name for Type instances. /// - /// For example, 'int', 'String', 'MyClass', 'List'. + /// For example: `'int'`, `'String'`, `'MyClass'`, `'List'`. final String? typeName; /// The length of the object, if applicable. @@ -98,7 +98,7 @@ class ClassMetaData { /// The dart type name for the object. /// - /// For example, 'int', 'List', 'Null' + /// For example: `'int'`, `'List'`, `'Null'`. String? get dartName => classRef.name; /// Class ref for the class metadata. diff --git a/dwds/lib/src/readers/asset_reader.dart b/dwds/lib/src/readers/asset_reader.dart index 0b5ace038..f4f9ef2ee 100644 --- a/dwds/lib/src/readers/asset_reader.dart +++ b/dwds/lib/src/readers/asset_reader.dart @@ -11,7 +11,7 @@ import 'package:package_config/package_config.dart'; abstract class AssetReader { /// Base path of the application, for example, set up in the index file: /// - /// ``` + /// ```html /// /// /// diff --git a/dwds/lib/src/services/expression_evaluator.dart b/dwds/lib/src/services/expression_evaluator.dart index 051a7d81e..2824064ea 100644 --- a/dwds/lib/src/services/expression_evaluator.dart +++ b/dwds/lib/src/services/expression_evaluator.dart @@ -45,10 +45,11 @@ class ExpressionEvaluator { static final _syntheticNameFilterRegex = RegExp('org-dartlang-debug:synthetic_debug_expression:.*:.*Error: '); - /// Find module path from the XHR call network error message received from chrome. + /// Find module path from the XHR call network error message + /// received from chrome. /// /// Example: - /// NetworkError: Failed to load 'http://.com/path/to/module.js?' + /// `NetworkError: Failed to load 'http://.com/path/to/module.js?'` static final _loadModuleErrorRegex = RegExp(r".*Failed to load '.*\.com/(.*\.js).*"); diff --git a/dwds/test/fixtures/project.dart b/dwds/test/fixtures/project.dart index b06b1d5c8..e0ce35fd2 100644 --- a/dwds/test/fixtures/project.dart +++ b/dwds/test/fixtures/project.dart @@ -47,8 +47,8 @@ class TestProject { ), ); - /// The URI for the package_config.json is located in: - /// /.dart_tool/package_config + /// The URI for the `package_config.json` is located in: + /// `/.dart_tool/package_config`. Uri get packageConfigFile => p.toUri( p.join( absolutePackageDirectory,