-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(Re-)move client API route #1469
Comments
As I've explained before, it can't be a command-line tool separate from Knora, because it relies on |
In fact, it relies on:
The fact that all this functionality existed already in Knora is what made it possible to add the client code generation so easily. It would be possible to refactor all this code to separate it from the triplestore, load the ontologies from files, and separate it from Akka, but it would be a huge amount of work. If you don't want to have the client code API active on the live system, I suggest we just add a config option to disable it. |
Can it be an in-memory triplestore? Then only the necessary responders could be started without the need for an external graphdb, sipi, and redis. |
|
The SPARQL queries used by |
Great, having an in-memory triplestore, could also simplify testing. |
This doesn‘t look to bad: http://graphdb.ontotext.com/documentation/free/devhub/embeddedgraphdb.html |
Sure, if you want to use it for testing, too. If you only want to use it for client code generation, the basic RDF4J |
I would like to suggest to move the generation of the client library files to a separate sub-project (like the upgrade tool).
There is no reason to have a live API route active, which will never be called when deployed into production since the client library needs to be already published at that point.
Also, this would make using the generator for the client code simpler, because only a command-line tool would need to be called, and not a full knora-stack started.
related: #1499
related: #1501
The text was updated successfully, but these errors were encountered: