-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
More helpful error messages on validation issue #94
Comments
Also, we need to contextualise the schema validation warnings:
|
@mmanciop @bripkens As I communicated with monaco-yaml dev about contextualize the schema validation warnings, for now it's impossible to change the warnings, they are only can accessible as read-only data. The data is generating from vscode-json-languageservice / yaml-language-server. (just as example: https://github.com/microsoft/vscode-json-languageservice/blob/main/src/services/jsonValidation.ts#L101)) In addition, yaml-language-server still uses vscode-nls, but vscode-json-languageservice has moved on to the new @ vscode/l10n. Updates in yaml-language-server may be needed. Finally, I assume we can only improve the parts like @bripkens mentioned in the description of the issue |
@roshan-gh, are you saying that we cannot modify validation errors before they get to the editor? |
@mmanciop yes exactly |
Would it be possible to wrap the worker in some custom code and in there to update the texts @roshan-gh? otelbin/src/contexts/EditorContext.tsx Lines 97 to 100 in 1d013b8
|
I will look into it and check it @bripkens |
The text was updated successfully, but these errors were encountered: