From cc25fb0f12f8b42878b64cd655294ca584087616 Mon Sep 17 00:00:00 2001 From: Lukasz Klimek <842586+lklimek@users.noreply.github.com> Date: Wed, 20 Mar 2024 15:53:44 +0100 Subject: [PATCH] doc(proto): minor improvements --- abci/types/types.pb.go | 1 + proto/tendermint/abci/types.proto | 1 + spec/abci++/api.md | 2 +- 3 files changed, 3 insertions(+), 1 deletion(-) diff --git a/abci/types/types.pb.go b/abci/types/types.pb.go index c23cd6030a..1590b4caab 100644 --- a/abci/types/types.pb.go +++ b/abci/types/types.pb.go @@ -1470,6 +1470,7 @@ type RequestProcessProposal struct { // Proposer's latest available app protocol version. ProposedAppVersion uint64 `protobuf:"varint,12,opt,name=proposed_app_version,json=proposedAppVersion,proto3" json:"proposed_app_version,omitempty"` // App and block version used to generate the block. + // App version MUST be verified by the app. Version *version.Consensus `protobuf:"bytes,13,opt,name=version,proto3" json:"version,omitempty"` // quorum_hash contains hash of validator quorum that will sign the block QuorumHash []byte `protobuf:"bytes,14,opt,name=quorum_hash,json=quorumHash,proto3" json:"quorum_hash,omitempty"` diff --git a/proto/tendermint/abci/types.proto b/proto/tendermint/abci/types.proto index 1428ce1306..4080fa9d44 100644 --- a/proto/tendermint/abci/types.proto +++ b/proto/tendermint/abci/types.proto @@ -366,6 +366,7 @@ message RequestProcessProposal { // Proposer's latest available app protocol version. uint64 proposed_app_version = 12; // App and block version used to generate the block. + // App version MUST be verified by the app. tendermint.version.Consensus version = 13; // quorum_hash contains hash of validator quorum that will sign the block bytes quorum_hash = 14; diff --git a/spec/abci++/api.md b/spec/abci++/api.md index 33be574039..cf0287f6e9 100644 --- a/spec/abci++/api.md +++ b/spec/abci++/api.md @@ -712,7 +712,7 @@ When a validator _p_ enters Tenderdash consensus round _r_, height _h_, in which | core_chain_lock_update | [tendermint.types.CoreChainLock](#tendermint-types-CoreChainLock) | | Next core-chain-lock-update for validation in ABCI. | | proposer_pro_tx_hash | [bytes](#bytes) | | ProTxHash of the original proposer of the block. | | proposed_app_version | [uint64](#uint64) | | Proposer's latest available app protocol version. | -| version | [tendermint.version.Consensus](#tendermint-version-Consensus) | | App and block version used to generate the block. | +| version | [tendermint.version.Consensus](#tendermint-version-Consensus) | | App and block version used to generate the block. App version MUST be verified by the app. | | quorum_hash | [bytes](#bytes) | | quorum_hash contains hash of validator quorum that will sign the block |