chore: fix tests

dashpay · Mar 19, 2024 · f15c6d1 · f15c6d1
1 parent a316c2b
commit f15c6d1
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 1 deletion.
diff --git a/internal/consensus/state_data.go b/internal/consensus/state_data.go
@@ -314,6 +314,8 @@ func (s *StateData) proposalIsTimely() error {
 				errPrevoteProposalNotTimely, s.Height, s.Round, s.Proposal.Timestamp, s.state.LastBlockTime,
 			)
 		}
+
+		return nil
 	}
 
 	sp := s.state.ConsensusParams.Synchrony.SynchronyParamsOrDefaults()

diff --git a/types/proposal_test.go b/types/proposal_test.go
@@ -334,7 +334,7 @@ func TestIsTimely(t *testing.T) {
 			}
 
 			ti := p.CheckTimely(testCase.recvTime, sp, testCase.round)
-			assert.Equal(t, testCase.expectTimely, ti)
+			assert.Equal(t, testCase.expectTimely, ti == 0)
 		})
 	}
 }
-Original file line number
+Diff line change
@@ Expand Up / @@ -314,6 +314,8 @@ func (s *StateData) proposalIsTimely() error { @@
     				errPrevoteProposalNotTimely, s.Height, s.Round, s.Proposal.Timestamp, s.state.LastBlockTime,
     			)
     		}
+    		return nil
     	}
     	sp := s.state.ConsensusParams.Synchrony.SynchronyParamsOrDefaults()
@@ Expand Down @@