Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(abci): allow overriding genesis time in InitChain #847

Merged
merged 1 commit into from
Jul 25, 2024

Conversation

lklimek
Copy link
Collaborator

@lklimek lklimek commented Jul 25, 2024

Issue being fixed or feature implemented

Dash Platform generates genesis time based on state of L1 chain.
We need a way to provide this genesis time to Tenderdash in real time.

What was done?

Added optional genesis_time to ResponseInitChain to allow abci app to specify it.

How Has This Been Tested?

Added unit test.

To be tested after integration into the Platform.

Breaking Changes

None

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have made corresponding changes to the documentation

For repository code-owners and collaborators only

  • I have assigned this pull request to a milestone

@lklimek lklimek added this to the v1.1 milestone Jul 25, 2024
Copy link
Member

@shumkov shumkov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@lklimek lklimek merged commit 03517ef into v1.1-dev Jul 25, 2024
19 checks passed
@lklimek lklimek deleted the feat/provide-genesis-time-from-abci-app branch July 25, 2024 11:06
lklimek added a commit that referenced this pull request Jul 29, 2024
* feat!: replace dash core quorum sign with quorum platformsign (#828)

* feat: replace  dash core quorum sign with quorum platformsign

* chore: fix Docker legacy warning

* test(e2e): fix e2e quorum sign mock

* build(deps): update dashd-go to v0.25.0

* build(deps): Bump bufbuild/buf-setup-action from 1.33.0 to 1.35.0 (#841)

Bumps [bufbuild/buf-setup-action](https://github.com/bufbuild/buf-setup-action) from 1.33.0 to 1.35.0.
- [Release notes](https://github.com/bufbuild/buf-setup-action/releases)
- [Commits](bufbuild/buf-setup-action@v1.33.0...v1.35.0)

---
updated-dependencies:
- dependency-name: bufbuild/buf-setup-action
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* build(dependabot): run dependabot on default branch, not master (#843)

* chore(release): update changelog and version to 1.1.0-dev.1 (#842)

* fix: address already in use (#845)

* fix: address already in use

* fix: always sleep

* fix: active validators not always connected to each other (#844)

* chore(dash): decrease log verbosity in validator conn executor

* fix(node): validator conn executor not started correctly

* fix: panic on full node

* fix: dash dialer fails to lookup nodes in addressbook

* chore(release): update changelog and version to 1.1.0-dev.2 (#846)

* feat(abci): allow overriding genesis time in InitChain (#847)

* chore(release): update changelog and version to 1.1.0-dev.3 (#848)

* fix: validators form islands on genesis (#850)

* chore(release): update changelog and version to 1.1.0

---------

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Ivan Shumkov <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants