-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: allow renaming when rebuilding dask-awkward Arrays #554
base: main
Are you sure you want to change the base?
Conversation
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #554 +/- ##
==========================================
- Coverage 93.06% 92.87% -0.20%
==========================================
Files 23 22 -1
Lines 3290 3395 +105
==========================================
+ Hits 3062 3153 +91
- Misses 228 242 +14 ☔ View full report in Codecov by Sentry. |
I am attending pydata global right now, but I'll get to this. I notice that coverage reports that your code isn't touched. |
It looks like this is ready? It maybe should have an explicit test for |
Yes, it's ready 👍 |
I meant calling ...but actually I see that a_comp is all zeros, so something else is going on? |
This follows the implementation of
dask.array.Array
: https://github.com/dask/dask/blob/main/dask/array/core.py#L1442With this PR it is possible to
dask.graph_manipulation.clone
graphs containingdask_awkward.Arrays
.