use color of active RGB profile instead of no color at all

[wschlich]

I'm using the "All White" profile by default in order to have a good default illumination of all keys.
When using the CPU monitor applet, the keys that do not indicate current CPU usage have their backlight/color turned off completely. This makes it hard to see the inscription of these non-illuminated keys. Instead of turning backlight/color off, the CPU monitor applet should feature a toggle option that results in displaying the non-indicating keys in the color determined by the active RGB profile.

[wschlich]

@F-DALLA-VALLE What do you think about this? Version 1.0.6 still does not support the feature I requested, making the keys that currently don't indicate any load stay unilluminated :(

[corykim]

@wschlich We needed to add the ability to delete past signals in order for this to work. That's been done. The change will be incorporated in the next release, or you can try the latest from master in the desktop's developer mode.

[DanielBaulig]

@corykim Is this the API you mentioned?
https://www.daskeyboard.io/api-resources/signal/delete-signal/

Is it worth taking a shot at this and sending a pull request?

[DanielBaulig]

Uh, just noticed this:
b8b5b70

Do I need to reinstall the applet from marketplace for this to start working?
Just tried that, applet still "switches off" the keys not indicating CPU usage.

[Mubramaj]

This change has not been released on the marketplace yet. If you want to test it you can clone it and launch the applet in dev mode.

[corykim]

It’s been a while since I’ve been involved with this, but IIRC not everyone agreed as to whether the feature you proposed should be implemented. It is OSS, though, so...

[wschlich]

This change has not been released on the marketplace yet. If you want to test it you can clone it and launch the applet in dev mode.

Saved the ZIP snapshot of the master branch on disk, unpacked it, then trying to load the applet via the dev menu results in the following error:

Unable to start applet instance with uuid a1c46ca6-1d9c-4dac-afb7-f7efa98ec4ed

The log file shows:

{"level":"error","message":"2019-02-19 04:48:58.4858 startAppletInstance failed: Http failure response for http://localhost:27302/start/a1c46ca6-1d9c-4dac-afb7-f7efa98ec4ed: 400 Bad Request","timestamp":"2019-02-19T15:48:58.505Z"}

[Mubramaj]

@wschlich you have to go on applet folder you unzip and run yarn or npm install the try again

[wschlich]

@Mubramaj Thanks, that worked! :)

[wschlich]

Using the master snapshot, it works perfectly well. Keys not being used for indicating CPU usage show the color of the active RGB profile. Awesome! I don't understand why this behaviour should not be used by default.

[wschlich]

@Mubramaj @corykim Can you please make a new release that incorporates commit b8b5b70 and post it to the marketplace?

[wschlich]

I don't understand why 9f93853 was committed to master while b8b5b70 wasn't :(