test_vecdot does not test for conjugation in the first parameter #312
Comments
asmeurer
added a commit
to asmeurer/array-api-compat
that referenced
this issue
Nov 19, 2024
Note that PyTorch uses its own vecdot directly for complex inputs,, which already does conjugation. This is currently untested by the test suite (data-apis/array-api-tests#312) Fixes data-apis#200.
asmeurer
added a commit
to asmeurer/array-api-strict
that referenced
this issue
Nov 19, 2024
This is currently untested by the test suite (data-apis/array-api-tests#312) Fixes data-apis#97.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
It looks like there isn't any values testing in test_vecdot at all for floating-point arguments. We should add something so that the conjugation can be tested, since this is something many implementations miss (e.g., data-apis/array-api-compat#200, data-apis/array-api-strict#97).
The text was updated successfully, but these errors were encountered: