fix: prevent null reference error

data-fair · May 15, 2024 · e3cd90f · e3cd90f
1 parent 122d5fa
commit e3cd90f
Show file tree

Hide file tree

Showing 2 changed files with 17 additions and 1 deletion.
diff --git a/api/src/routers/plugins.js b/api/src/routers/plugins.js
@@ -53,6 +53,9 @@ tmp.setGracefulCleanup()
  * @property {object} access
  */
 
+/** @typedef {import('../types.js').Access} Access */
+/** @typedef {import('../types.js').PrivateAccess} PrivateAccess */
+
 /**
  * For compatibility with old plugins
  * @param {PluginData} plugin
@@ -139,7 +142,8 @@ router.get('/', asyncHandler(async (req, res) => {
   for (const dir of dirs) {
     /** @type {PluginDataWithConfig} */
     const pluginInfo = await fs.readJson(path.join(pluginsDir, dir, 'plugin.json'))
-    let access
+    /** @type {Access}  */
+    let access = { public: false, privateAccess: [] }
     const accessFilePath = path.join(pluginsDir, dir + '-access.json')
     if (await fs.pathExists(accessFilePath)) {
       access = await fs.readJson(path.join(pluginsDir, dir + '-access.json'))

diff --git a/api/src/types.ts b/api/src/types.ts
@@ -0,0 +1,12 @@
+/* eslint-disable */
+
+export type PrivateAccess {
+  type: 'user' | 'organization'
+  id: string
+  name: string
+}
+
+export type Access {
+  public: boolean;
+  privateAccess: PrivateAccess[]
+}