Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Map language is not the same as app language #685

Closed
yuvalbl opened this issue Jun 3, 2021 · 1 comment · Fixed by #767
Closed

[Bug] Map language is not the same as app language #685

yuvalbl opened this issue Jun 3, 2021 · 1 comment · Fixed by #767
Assignees
Labels
bug Something isn't working Priority 2 Priority 2
Milestone

Comments

@yuvalbl
Copy link
Collaborator

yuvalbl commented Jun 3, 2021

Describe the bug
A clear and concise description of what the bug is.

To Reproduce
Steps to reproduce the behavior:

  1. Go to home page
  2. See default map language (herbrew)
  3. change language to english
  4. See - map language is still hebrew

Expected behavior
When passing params to google maps, we should pass language arguments as well to determined the proper language (should be the same as app language)

Screenshots
image

Environment
Browser: Chrome
Environment: Staging

@yuvalbl yuvalbl added the bug Something isn't working label Jun 3, 2021
@yuvalbl yuvalbl added this to the v0.6.0 milestone Jun 3, 2021
@daniel-ilan daniel-ilan self-assigned this Jun 23, 2021
@yuvalbl yuvalbl added the Priority 2 Priority 2 label Jun 30, 2021
@yuvalbl yuvalbl modified the milestones: v0.6.0, v0.7.0 Jun 30, 2021
@daniel-ilan
Copy link
Collaborator

daniel-ilan commented Jul 17, 2021

We use react-leaflet-google-layer and it is using js-api-loader to load the configuration for the maps.
After consulting with @aviklai, he pointed that the issue is with that package (built by google maps itself) - googlemaps/js-api-loader#210.

We tried:

  1. Giving a key and changing it when changing the language to the react leaflet map instance & to the ReactLeafletGoogleMaps layer itself.
  2. Manually deleting and resetting the script that is added when loading a google map

Currently the only solution that works is to reload the page with the new language - This is a temporary solution that will be addressed at 0.8

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Priority 2 Priority 2
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants