Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SQL Connector Bindings + SQL Execution API #44

Merged
merged 5 commits into from
May 6, 2024
Merged

SQL Connector Bindings + SQL Execution API #44

merged 5 commits into from
May 6, 2024

Conversation

zacdav-db
Copy link
Contributor

  • SQL execution API
    • Documentation
    • Tests
  • SQL connector bindings via reticulate
    • Documentation
    • Tests
  • Adjustments to handling of workspace URL in db_host() to force https and no longer require a scheme

Zac Davies added 2 commits April 26, 2024 09:53
- Adjusting db_host(), no longer required to specify scheme (https/http) as brickster now will override to https.
@zacdav-db zacdav-db self-assigned this May 6, 2024
@codecov-commenter
Copy link

codecov-commenter commented May 6, 2024

Codecov Report

Attention: Patch coverage is 52.38095% with 70 lines in your changes are missing coverage. Please review.

Project coverage is 83.77%. Comparing base (06b8821) to head (5630959).
Report is 2 commits behind head on main.

Files Patch % Lines
R/sql-connector.R 2.94% 66 Missing ⚠️
R/databricks-helpers.R 55.55% 4 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #44      +/-   ##
==========================================
- Coverage   86.14%   83.77%   -2.38%     
==========================================
  Files          22       26       +4     
  Lines        2577     2742     +165     
==========================================
+ Hits         2220     2297      +77     
- Misses        357      445      +88     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zacdav-db zacdav-db merged commit f172e45 into main May 6, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants