Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing volume write function adding bytes #39

Merged
merged 2 commits into from
Mar 25, 2024
Merged

Fixing volume write function adding bytes #39

merged 2 commits into from
Mar 25, 2024

Conversation

zacdav-db
Copy link
Contributor

Addressing #38

  • Using httr2::req_body_file instead of multi-part upload
  • Adding httr2::req_progress indicators for volume upload and download db_volume_write/db_volume_read

Zac Davies added 2 commits March 22, 2024 11:30
 - addressing issue with `db_volume_write` that was causing bytes to be injected
 - adding httr2 progress indicators for `db_volume_write` and `db_volume_read`
 - removing DT from Description file
@zacdav-db zacdav-db self-assigned this Mar 22, 2024
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 0% with 8 lines in your changes are missing coverage. Please review.

Project coverage is 11.48%. Comparing base (6e7a3fa) to head (817d43c).

Files Patch % Lines
R/volume-fs.R 0.00% 8 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #39      +/-   ##
==========================================
+ Coverage   11.47%   11.48%   +0.01%     
==========================================
  Files          23       23              
  Lines        2746     2742       -4     
==========================================
  Hits          315      315              
+ Misses       2431     2427       -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zacdav-db zacdav-db merged commit 48718be into main Mar 25, 2024
7 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants