Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to httr2 #8

Open
hadley opened this issue Jun 23, 2023 · 4 comments
Open

Switch to httr2 #8

hadley opened this issue Jun 23, 2023 · 4 comments

Comments

@hadley
Copy link
Contributor

hadley commented Jun 23, 2023

httr is mostly in maintenance mode, so I'd recommend using httr2 instead. It includes nice features for automatically retrying on failure, e.g. https://httr2.r-lib.org/reference/req_retry.html.

@nfx
Copy link
Collaborator

nfx commented Jun 24, 2023

Thank you for the feature request! Currently, the team operates in a limited capacity, carefully prioritizing, and we cannot provide a timeline to implement this feature. Please make a Pull Request if you'd like to see this feature sooner, and we'll guide you through the journey.

@nfx
Copy link
Collaborator

nfx commented Jun 24, 2023

one of the iterations was using httr2, though I found it difficult to inject headers to the request as well as using the VERB method https://github.com/databrickslabs/databricks-sdk-r/blob/main/R/api_client.R#L188-L217

@hadley
Copy link
Contributor Author

hadley commented Jun 25, 2023

It should be easier to do that with httr2 😄 You might have missed https://httr2.r-lib.org/reference/req_method.html. I can also take a look at a PR.

@zacdav-db
Copy link

I may be able to do this once I finish some other work given that brickster already uses httr2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants