Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add deploy-dashboard command #301

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from
Draft

Add deploy-dashboard command #301

wants to merge 4 commits into from

Conversation

nfx
Copy link
Collaborator

@nfx nfx commented Sep 27, 2024 •
edited by JCZuurmond
Loading

Add deploy-dashboard command to replace create-dashboard as the later is ambiguous and means create-or-update

@nfx nfx changed the title Added update-dashboard command Added deploy-dashboard command Sep 27, 2024
@nfx nfx requested a review from JCZuurmond September 27, 2024 17:22
JCZuurmond
JCZuurmond reviewed Sep 30, 2024
View reviewed changes
Copy link
Contributor

@JCZuurmond JCZuurmond left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good to me. Why introduce the alias?

@nfx
Copy link
Collaborator Author

nfx commented Sep 30, 2024

@JCZuurmond because create here is ambiguous and means create-or-update

@JCZuurmond JCZuurmond changed the title Added deploy-dashboard command Add deploy-dashboard command Sep 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JCZuurmond JCZuurmond JCZuurmond approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nfx @JCZuurmond