Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature Filter dashboard widgets using date select #308

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Feature Filter dashboard widgets using date select #308

wants to merge 1 commit into from

Conversation

namanvats
Copy link

This one adds Filter dashboard widgets using date select as requested here : #170

@namanvats namanvats mentioned this pull request Oct 22, 2024
Open
@namanvats
Copy link
Author

Please review @JCZuurmond

JCZuurmond
JCZuurmond reviewed Oct 23, 2024
View reviewed changes
Copy link
Contributor

@JCZuurmond JCZuurmond left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code changes look good, but missing an integration test to show the date picker works. Please attach a screenshot of the created dashboard

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JCZuurmond JCZuurmond JCZuurmond left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@namanvats @JCZuurmond