New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TODO] this is not so correct implementation, but is fine for now #278

Open

nfx opened this issue Nov 4, 2024 · 0 comments

Labels

Collaborator

nfx commented Nov 4, 2024

See more context:

sandbox/go-libs/lite/logger.go

Lines 92 to 97 in a89763e

    
           func (l *friendlyHandler) WithGroup(name string) slog.Handler { 
        
           	// TODO: this is not so correct implementation, but is fine for now 
        
           	return &friendlyHandler{ 
        
           		Handler: l.Handler.WithGroup(name), 
        
           		w:       l.w, 
        
           		attrs:   []slog.Attr{slog.String("group", name)},

nfx added the tech debt label

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment