Add DirectFsAccess progress encoder
#3315
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JCZuurmond
had a problem deploying
to
account-admin
GitHub Actions
Failure
JCZuurmond
added
the
feat/migration-progress
|
❌ 50/54 passed, 4 failed, 23m44s total ❌ test_workflow_linter_lints_python_wheel_task: databricks.labs.blueprint.parallel.ManyError: Detected 7 failures: TypeError: LakeviewAPI.create() got an unexpected keyword argument 'parent_path' (1m26.942s)❌ test_running_real_migration_progress_job: databricks.labs.blueprint.parallel.ManyError: Detected 7 failures: TypeError: LakeviewAPI.create() got an unexpected keyword argument 'parent_path' (1m49.131s)❌ test_fix_dashboard: databricks.labs.blueprint.parallel.ManyError: Detected 7 failures: TypeError: LakeviewAPI.create() got an unexpected keyword argument 'parent_path' (38.705s)❌ test_workflow_linter_lints_job_with_wheel_dependency: databricks.labs.blueprint.parallel.ManyError: Detected 7 failures: TypeError: LakeviewAPI.create() got an unexpected keyword argument 'parent_path' (34.312s)Running from acceptance #7376 |
6 tasks
nfx
requested changes
Nov 18, 2024
| from databricks.labs.ucx.source_code.directfs_access import DirectFsAccessOwnership | ||
|
|
||
|
|
||
| class DirectFsAccessProgressEncoder(ProgressEncoder[DirectFsAccess]): |
There was a problem hiding this comment.
shouldn't it belong to a notebook/sql query/dashboard, rather than being it's own top-level entity?
| A direct filesystem is by definition a failure as it is not supported in Unity Catalog. | ||
| """ | ||
| historical = super()._encode_record_as_historical(record) | ||
| failure = "Direct filesystem access is not supported in Unity Catalog" |
There was a problem hiding this comment.
Suggested change
| failure = "Direct filesystem access is not supported in Unity Catalog" | |
| failure = "Direct filesystem access is not supported in Unity Catalog: {record.path}" |
and add it to a notebook/view/sql query/dashboard
|
Closing this PR and moving the logic to become part of business resources like mentioned, see design doc |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Add
DirectFsAccessProgressEncoderto add the query problems to the history log for using it in the migration progressLinked issues
Progresses #3045
Breaks up #3112
Functionality
table-migration-experimentalTests