-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
More FlightSQL endpoints #240
Comments
Would it make sense to use or combine efforts on this impl? https://github.com/datafusion-contrib/datafusion-federation/tree/main/datafusion-flight-sql-server |
@ahirner i apologize for missing your comment - not sure how I missed it. This issue is specifically for improving the flight sql server implementation within dft. The client capabilities would be improved through other issues. That being said I think I saw there was a flight sql table provider / factory and I do think it would make sense to include that here. I have been on a brief dft pause for the holidays but I will be getting back into it shortly and can look into it more then. Depending on the apis they implement in that repo it may be trivial to add this with a table provider factory in case you're interested in trying it out. |
Thanks, I thought this issue was about the server. |
@ahirner perhaps i misunderstood then - i looked at the example in the link you provided and it seemed to be more about a client implementation (it created a |
It's about the server implementation in |
Ah thanks for that. I will have to look a little further into it - on the surface it may make sense but the direction im moving with this is to have a much more opinionated / integrated setup (for example with metrics endpoint on the server and using same session context across local client and server to facilitate debugging. Some parts that are limited to just plugging the session state into their |
Im also planning / hoping to have a builder pattern in place where any endpoints implementation can be customized by user. |
do_get_statement
The text was updated successfully, but these errors were encountered: