Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More FlightSQL endpoints #240

Open
1 task
matthewmturner opened this issue Nov 8, 2024 · 7 comments
Open
1 task

More FlightSQL endpoints #240

matthewmturner opened this issue Nov 8, 2024 · 7 comments

Comments

@matthewmturner
Copy link
Collaborator

matthewmturner commented Nov 8, 2024

  • do_get_statement
@ahirner
Copy link

ahirner commented Nov 28, 2024

Would it make sense to use or combine efforts on this impl? https://github.com/datafusion-contrib/datafusion-federation/tree/main/datafusion-flight-sql-server

@matthewmturner
Copy link
Collaborator Author

@ahirner i apologize for missing your comment - not sure how I missed it.

This issue is specifically for improving the flight sql server implementation within dft. The client capabilities would be improved through other issues. That being said I think I saw there was a flight sql table provider / factory and I do think it would make sense to include that here. I have been on a brief dft pause for the holidays but I will be getting back into it shortly and can look into it more then.

Depending on the apis they implement in that repo it may be trivial to add this with a table provider factory in case you're interested in trying it out.

@ahirner
Copy link

ahirner commented Dec 18, 2024

Thanks, I thought this issue was about the server.

@matthewmturner
Copy link
Collaborator Author

@ahirner perhaps i misunderstood then - i looked at the example in the link you provided and it seemed to be more about a client implementation (it created a FlightSqlServiceClient whereas the server implementation uses FlightServiceServer).

@ahirner
Copy link

ahirner commented Dec 18, 2024

It's about the server implementation in service.rs. We are using this crate's implementation to run a flightsql server in production.
https://github.com/datafusion-contrib/datafusion-federation/blob/main/datafusion-flight-sql-server/src/service.rs

@matthewmturner
Copy link
Collaborator Author

Ah thanks for that. I will have to look a little further into it - on the surface it may make sense but the direction im moving with this is to have a much more opinionated / integrated setup (for example with metrics endpoint on the server and using same session context across local client and server to facilitate debugging.

Some parts that are limited to just plugging the session state into their SessionStateProvider may work fine (object stores, table providers, etc) but then that may hinder the local experience ive been working on.

@matthewmturner
Copy link
Collaborator Author

Im also planning / hoping to have a builder pattern in place where any endpoints implementation can be customized by user.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants