Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Don't silence disk full errors with SQLite #208

Merged
merged 2 commits into from
Dec 30, 2024
Merged

fix: Don't silence disk full errors with SQLite #208

merged 2 commits into from
Dec 30, 2024

Conversation

peasee
Copy link
Collaborator

@peasee peasee commented Dec 29, 2024

🗣 Description

  • SQLite incorrectly treats a disk full error as a retriable error. It is not retriable, so don't wrap it in a retriable error.

@peasee peasee added the bug Something isn't working label Dec 29, 2024
@peasee peasee self-assigned this Dec 29, 2024
@peasee peasee merged commit 7fe456a into spiceai Dec 30, 2024
3 checks passed
@peasee peasee deleted the fix/sqlite-silences-disk-full branch December 30, 2024 05:46
@ewgenius ewgenius mentioned this pull request Jan 2, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@phillipleblanc phillipleblanc phillipleblanc approved these changes

@sgrebnov sgrebnov Awaiting requested review from sgrebnov

Assignees

@peasee peasee

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@peasee @phillipleblanc