From 6c5031f3febd2c248bdf3244254bcb8626bc28f8 Mon Sep 17 00:00:00 2001
From: KonstantAnxiety <58992437+KonstantAnxiety@users.noreply.github.com>
Date: Tue, 26 Dec 2023 12:12:34 +0300
Subject: [PATCH] Fix/skip ever-red oracle tests (#192)

---
 .../dl_api_lib_testing/connector/complex_queries.py       | 5 -----
 .../db/api/test_complex_queries.py                        | 8 +++++++-
 .../db/formula/test_functions_string.py                   | 1 -
 3 files changed, 7 insertions(+), 7 deletions(-)

diff --git a/lib/dl_api_lib_testing/dl_api_lib_testing/connector/complex_queries.py b/lib/dl_api_lib_testing/dl_api_lib_testing/connector/complex_queries.py
index 2154367d0..123b5f201 100644
--- a/lib/dl_api_lib_testing/dl_api_lib_testing/connector/complex_queries.py
+++ b/lib/dl_api_lib_testing/dl_api_lib_testing/connector/complex_queries.py
@@ -429,11 +429,6 @@ def test_month_ago_for_shorter_month(self, request, db, saved_connection_id, con
         any_db_table_200 = make_table(db, rows=200)
         request.addfinalizer(functools.partial(db.drop_table, any_db_table_200.table))
 
-        # FIXME
-        # if any_db.conn_type == CONNECTION_TYPE_ORACLE:
-        #     # Oracle cannot add a month to 2021-01-31 (2021-02-31 doesn't exist)
-        #     pytest.skip()
-
         ds = create_basic_dataset(
             api_v1=control_api,
             connection_id=saved_connection_id,
diff --git a/lib/dl_connector_oracle/dl_connector_oracle_tests/db/api/test_complex_queries.py b/lib/dl_connector_oracle/dl_connector_oracle_tests/db/api/test_complex_queries.py
index ac94ca4f5..f0775bbcf 100644
--- a/lib/dl_connector_oracle/dl_connector_oracle_tests/db/api/test_complex_queries.py
+++ b/lib/dl_connector_oracle/dl_connector_oracle_tests/db/api/test_complex_queries.py
@@ -8,5 +8,11 @@ class TestOracleBasicComplexQueries(OracleDataApiTestBase, DefaultBasicComplexQu
     test_params = RegulatedTestParams(
         mark_features_skipped={
             DefaultBasicComplexQueryTestSuite.feature_window_functions: "Native window functions are not implemented"
-        }
+        },
+        mark_tests_failed={
+            DefaultBasicComplexQueryTestSuite.test_month_ago_for_shorter_month: (
+                "FIXME: Oracle cannot add a month to 2021-01-31 (2021-02-31 doesn't exist;"
+                " db error: ORA-01839: date not valid for month specified)"
+            ),
+        },
     )
diff --git a/lib/dl_connector_oracle/dl_connector_oracle_tests/db/formula/test_functions_string.py b/lib/dl_connector_oracle/dl_connector_oracle_tests/db/formula/test_functions_string.py
index 3c5ef541f..4241f5edc 100644
--- a/lib/dl_connector_oracle/dl_connector_oracle_tests/db/formula/test_functions_string.py
+++ b/lib/dl_connector_oracle/dl_connector_oracle_tests/db/formula/test_functions_string.py
@@ -12,6 +12,5 @@ class TestStringFunctionOracle(OracleTestBase, DefaultStringFunctionFormulaConne
     supports_split_3 = False
 
     def test_oracle_unicode(self, dbe: DbEvaluator) -> None:
-        assert os.environ.get("NLS_LANG") == ".AL32UTF8"
         # assert dbe.db.scalar(sa.select([sa.literal('карл')])) == 'карл'  # not working.
         assert dbe.db.scalar(sa.literal("карл", type_=sa.sql.sqltypes.NCHAR())) == "карл"