From 73954e1a2de4553a94a6458e9e2e48726fcf624b Mon Sep 17 00:00:00 2001 From: Nikolay Proskurin Date: Mon, 20 Nov 2023 20:53:56 +0100 Subject: [PATCH] comments cleanup --- .../formula/definitions/functions_datetime.py | 2 +- .../formula/definitions/functions_string.py | 10 ++++------ .../formula/definitions/operators_binary.py | 2 +- 3 files changed, 6 insertions(+), 8 deletions(-) diff --git a/lib/dl_connector_ydb/dl_connector_ydb/formula/definitions/functions_datetime.py b/lib/dl_connector_ydb/dl_connector_ydb/formula/definitions/functions_datetime.py index f5c2010e3..816bf43e9 100644 --- a/lib/dl_connector_ydb/dl_connector_ydb/formula/definitions/functions_datetime.py +++ b/lib/dl_connector_ydb/dl_connector_ydb/formula/definitions/functions_datetime.py @@ -170,7 +170,7 @@ def _datetrunc2_yql_impl(date_ctx, unit_ctx): # type: ignore # today base.FuncToday( variants=[ - V(D.YQL, sa.func.CurrentUtcDate), # https://yql.yandex-team.ru/docs/ydb/misc/not_yet_supported + V(D.YQL, sa.func.CurrentUtcDate), # https://ydb.tech/en/docs/yql/reference/syntax/not_yet_supported#now ] ), # week diff --git a/lib/dl_connector_ydb/dl_connector_ydb/formula/definitions/functions_string.py b/lib/dl_connector_ydb/dl_connector_ydb/formula/definitions/functions_string.py index c31a6b3b3..74310c529 100644 --- a/lib/dl_connector_ydb/dl_connector_ydb/formula/definitions/functions_string.py +++ b/lib/dl_connector_ydb/dl_connector_ydb/formula/definitions/functions_string.py @@ -144,12 +144,10 @@ ), # regexp_extract # TODO: YQL - # https://yql.yandex-team.ru/docs/ydb/udf/list/hyperscan - # Problem: - # “По умолчанию все функции работают в однобайтовом режиме, но если - # регулярное выражение является валидной UTF-8 строкой, но не является - # валидной ASCII строкой, — автоматически включается режим UTF-8.” - # Problem: can't use higher-order functions yet. + # https://ydb.tech/en/docs/yql/reference/udf/list/hyperscan + # Problem: "By default, all functions work in the single-byte mode. + # However, if the regular expression is a valid UTF-8 string but is not a valid ASCII string, + # the UTF-8 mode is enabled automatically." However, we can't use higher-order functions yet. # replace base.FuncReplace( variants=[ diff --git a/lib/dl_connector_ydb/dl_connector_ydb/formula/definitions/operators_binary.py b/lib/dl_connector_ydb/dl_connector_ydb/formula/definitions/operators_binary.py index 8ec6cb311..3a3ab1a96 100644 --- a/lib/dl_connector_ydb/dl_connector_ydb/formula/definitions/operators_binary.py +++ b/lib/dl_connector_ydb/dl_connector_ydb/formula/definitions/operators_binary.py @@ -104,7 +104,7 @@ # / base.BinaryDivInt( variants=[ - # See also: https://yql.yandex-team.ru/docs/ydb/?singlePage=true#_syntax_pragma_classicdivision + # See also: https://ydb.tech/en/docs/yql/reference/syntax/pragma#classicdivision V(D.YQL, lambda x, y: sa.cast(x, sa.FLOAT) / y), ] ),