From ad03ba8e11ff3eaba66a5065530e1df173c54772 Mon Sep 17 00:00:00 2001 From: KonstantAnxiety <58992437+KonstantAnxiety@users.noreply.github.com> Date: Tue, 24 Oct 2023 14:22:48 +0300 Subject: [PATCH] Add missing request fixture to array contains tests (#35) --- .../connector/data_api_suites.py | 18 ++++++++++-------- 1 file changed, 10 insertions(+), 8 deletions(-) diff --git a/lib/dl_api_lib_testing/dl_api_lib_testing/connector/data_api_suites.py b/lib/dl_api_lib_testing/dl_api_lib_testing/connector/data_api_suites.py index 922bf6be4..125b40b77 100644 --- a/lib/dl_api_lib_testing/dl_api_lib_testing/connector/data_api_suites.py +++ b/lib/dl_api_lib_testing/dl_api_lib_testing/connector/data_api_suites.py @@ -70,9 +70,9 @@ def test_duplicated_expressions( ds.result_schema["Measure 1"] = ds.field(formula=f"SUM([{data_api_test_params.summable_field}])") ds.result_schema["Measure 2"] = ds.field(formula=f"SUM([{data_api_test_params.summable_field}])") - result_resp = self.get_result(ds, data_api, field_names=( - "Measure 1", "Measure 2", data_api_test_params.two_dims[0] - )) + result_resp = self.get_result( + ds, data_api, field_names=("Measure 1", "Measure 2", data_api_test_params.two_dims[0]) + ) rows = get_data_rows(result_resp) min_row_cnt = 2 # just an arbitrary number assert len(rows) > min_row_cnt @@ -80,7 +80,7 @@ def test_duplicated_expressions( def _test_contains( self, - request, + request: pytest.FixtureRequest, db: Db, saved_connection_id: str, dataset_params: dict, @@ -142,6 +142,7 @@ def check_filter(field_title: str, filter_value: Any) -> None: @for_features(array_support) def test_array_contains_filter( self, + request: pytest.FixtureRequest, db: Db, saved_connection_id: str, dataset_params: dict, @@ -149,12 +150,13 @@ def test_array_contains_filter( data_api: SyncHttpDataApiV2, ) -> None: self._test_contains( - db, saved_connection_id, dataset_params, control_api, data_api, WhereClauseOperation.CONTAINS + request, db, saved_connection_id, dataset_params, control_api, data_api, WhereClauseOperation.CONTAINS ) @for_features(array_support) def test_array_not_contains_filter( self, + request: pytest.FixtureRequest, db: Db, saved_connection_id: str, dataset_params: dict, @@ -162,7 +164,7 @@ def test_array_not_contains_filter( data_api: SyncHttpDataApiV2, ) -> None: self._test_contains( - db, saved_connection_id, dataset_params, control_api, data_api, WhereClauseOperation.NOTCONTAINS + request, db, saved_connection_id, dataset_params, control_api, data_api, WhereClauseOperation.NOTCONTAINS ) @pytest.mark.parametrize( @@ -179,7 +181,7 @@ def test_array_not_contains_filter( @for_features(array_support) def test_array_contains_field( self, - request, + request: pytest.FixtureRequest, db: Db, saved_connection_id: str, dataset_params: dict, @@ -409,7 +411,7 @@ def test_distinct_with_nonexistent_filter( def test_date_filter_distinct( self, - request, + request: pytest.FixtureRequest, db: Db, saved_connection_id: str, dataset_params: dict,