Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Do not merge!] Test the diff script in CI #17

Closed
wants to merge 2 commits into from
Closed

[Do not merge!] Test the diff script in CI #17

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9e86987
Switched to git diffs via dl-git
altvod Oct 13, 2023
946feca
Test the diff script
altvod Oct 13, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions .github/workflows/main.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,11 +75,12 @@ jobs:
fetch-depth: 0
- run: git config --global --add safe.directory .
- run: git config --global --add safe.directory /__w/${{ github.event.repository.name }}/${{ github.event.repository.name }}
- run: git fetch origin main
# FIXME: Remove this before merging!!!!!!!!!!!!!!!!
- run: git fetch origin use-dlgit-diff
- name: Get packages affected by changes in the current commit
id: get_affected
run: |
TARGET_DATA=$(bash /src/ci/gh_list_changes.sh ${{ github.event.pull_request.base.sha }} ${{ github.event.pull_request.head.sha }})
TARGET_DATA=$(. /venv/bin/activate && dl-git diff-paths --base ${{ github.event.pull_request.base.sha }} --head ${{ github.event.pull_request.head.sha }})
echo "$TARGET_DATA" > /tmp/targets.json
cat /tmp/targets.json
. /venv/bin/activate && detect-affected-packages \
Expand Down
1 change: 1 addition & 0 deletions docker_build/bake_ci.hcl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,7 @@ target "ci_with_src" {
"COPY --from=bake_ctx_dl_src_terrarium / /src/",
"COPY --from=bake_ctx_dl_src_ci / /src/",
"RUN . /venv/bin/activate && pip install -e /src/terrarium/bi_ci",
"RUN . /venv/bin/activate && pip install -e /src/terrarium/dl_gitmanager",
"RUN . /venv/bin/activate && cd /src/metapkg/ && poetry install --no-root --without=dev --with=ci",
# todo: include stubs into the metapkg pyproject.toml
"RUN . /venv/bin/activate && pip install -r /src/ci/requirements_types.txt"
Expand Down
2 changes: 2 additions & 0 deletions lib/dl_connector_clickhouse/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1,3 @@
# dl_connector_clickhouse

Connector to the ClickHouse database
1 change: 1 addition & 0 deletions lib/dl_connector_oracle/dl_connector_oracle/core/adapters_oracle.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,7 @@


class OracleConnLineConstructor(ClassicSQLConnLineConstructor[OracleConnTargetDTO]):
""""""
def _get_dsn_params(
self,
safe_db_symbols: Tuple[str, ...] = (),
Expand Down
2 changes: 1 addition & 1 deletion tools/taskfiles/taskfile_env.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ tasks:
$PYTHON -m venv $VENV_PATH
. $VENV_PATH/bin/activate
pip install -r requirements-localhost.txt
pip install -e $(realpath ../terrarium/dl_repmanager) $(realpath ../terrarium/bi_ci)
pip install -e $(realpath ../terrarium/dl_repmanager) $(realpath ../terrarium/bi_ci) $(realpath ../terrarium/dl_gitmanager)
status:
- test -f $VENV_PATH/bin/activate
# todo: deal with ci to skip ensure_venv
Expand Down
Loading