From 00675bb7e57910f9762797b7998a14bf70b17b38 Mon Sep 17 00:00:00 2001
From: Nikolay Proskurin <n1ckpr0s@yandex.ru>
Date: Fri, 13 Oct 2023 16:51:09 +0200
Subject: [PATCH] Add more result error tests

---
 .../db/data_api/result/test_errors.py         | 54 ++++++++++++++++++-
 1 file changed, 53 insertions(+), 1 deletion(-)

diff --git a/lib/dl_api_lib/dl_api_lib_tests/db/data_api/result/test_errors.py b/lib/dl_api_lib/dl_api_lib_tests/db/data_api/result/test_errors.py
index 72a4aca67..373432bc0 100644
--- a/lib/dl_api_lib/dl_api_lib_tests/db/data_api/result/test_errors.py
+++ b/lib/dl_api_lib/dl_api_lib_tests/db/data_api/result/test_errors.py
@@ -1,6 +1,9 @@
 from dl_api_client.dsmaker.primitives import ResultField
 from dl_api_lib_tests.db.base import DefaultApiTestBase
-from dl_constants.enums import CalcMode
+from dl_constants.enums import (
+    AggregationFunction,
+    CalcMode,
+)
 
 
 class TestResultErrors(DefaultApiTestBase):
@@ -22,3 +25,52 @@ def test_calcmode_formula_without_formula_field(self, saved_dataset, data_api):
         result_resp = data_api.get_result(dataset=ds, fields=[ds.find_field(title)], fail_ok=True)
         assert result_resp.status_code == 400
         assert result_resp.bi_status_code == "ERR.DS_API.FORMULA.PARSE.UNEXPECTED_EOF.EMPTY_FORMULA"
+
+    def test_filter_errors(self, saved_dataset, data_api):
+        ds = saved_dataset
+        ds.result_schema["New date"] = ds.field(formula="DATE(NOW())")  # just a date field
+        ds.result_schema["New bool"] = ds.field(formula='"P" = "NP"')  # just a bool field
+
+        # invalid value for date
+        result_resp = data_api.get_result(
+            dataset=ds,
+            fields=[ds.find_field(title="New date")],
+            filters=[ds.find_field(title="New date").filter("EQ", values=["Office Supplies"])],
+            fail_ok=True,
+        )
+        assert result_resp.status_code == 400
+        assert result_resp.bi_status_code == "ERR.DS_API.FILTER.INVALID_VALUE"
+
+        # a very special check for invalid bool values
+        result_resp = data_api.get_result(
+            dataset=ds,
+            fields=[ds.find_field(title="New date")],
+            filters=[ds.result_schema["New bool"].filter("EQ", values=[""])],
+            fail_ok=True,
+        )
+        assert result_resp.status_code == 400
+        assert result_resp.bi_status_code == "ERR.DS_API.FILTER.INVALID_VALUE"
+
+        # unknown field
+        result_resp = data_api.get_result(
+            dataset=ds,
+            fields=[ds.find_field(title="New date")],
+            filters=[ds.field(title="Made-up field").filter("EQ", values=["whatever"])],
+            fail_ok=True,
+        )
+        assert result_resp.status_code == 400
+        assert result_resp.bi_status_code == "ERR.DS_API.FIELD.NOT_FOUND"
+
+    def test_invalid_group_by_configuration(self, saved_dataset, data_api):
+        ds = saved_dataset
+        ds.result_schema["Measure"] = ds.field(title="Measure", aggregation=AggregationFunction.sum)
+
+        result_resp = data_api.get_result(
+            dataset=saved_dataset,
+            fields=[ds.find_field(title="Measure")],
+            disable_group_by=True,
+            fail_ok=True,
+        )
+        assert result_resp.status_code == 400
+        assert result_resp.bi_status_code == "ERR.DS_API.INVALID_GROUP_BY_CONFIGURATION"
+        assert result_resp.json["message"] == "Invalid parameter disable_group_by for dataset with measure fields"