Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(formula): BI-5959 apply mutations before adding formula to global dimensions during validation #733

Merged
merged 3 commits into from
Dec 2, 2024

Conversation

KonstantAnxiety
Copy link
Contributor

@KonstantAnxiety KonstantAnxiety commented Nov 29, 2024

Allows to use constant math expressions (e.g. 1 / 2 * 365) in measures used in window functions, which previously resulted in ERR.DS_API.FORMULA.VALIDATION.AGG.INCONSISTENT validation error

This change should also be virtually free in terms of performance thanks to stage caching

def implements_stage(stage: ProcessingStage) -> Callable[[StageProcType], StageProcType]:
"""
A parameterized decorator.
Mark a ``FormulaCompiler`` method as an implementation of a certain formula processing stage.
This adds the enabling of various caches and error handlers needed to optimize
formula generation and validation.
"""

@KonstantAnxiety KonstantAnxiety merged commit f7e591c into main Dec 2, 2024
64 checks passed
@KonstantAnxiety KonstantAnxiety deleted the konstasa/win-dim-const-ops-mutation branch December 2, 2024 11:02
@KonstantAnxiety KonstantAnxiety added the changelog Changes should be included in changelog label Dec 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog Changes should be included in changelog component/formula Formula type/fix Bug fixes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants