Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a feature to copy entries to workbooks #9

Merged
merged 10 commits into from
Nov 1, 2023

Conversation

bt4R9
Copy link
Contributor

@bt4R9 bt4R9 commented Oct 9, 2023

I've added a new feature that allows to copy entries to workbooks.

@bt4R9 bt4R9 requested a review from imsitnikov October 9, 2023 14:18
src/components/middlewares/decode-id.ts Show resolved Hide resolved
src/const/common.ts Outdated Show resolved Hide resolved
src/services/new/entry/utils/resolveNameCollisions.ts Outdated Show resolved Hide resolved
@bt4R9 bt4R9 force-pushed the feature-copy-entries-to-workbook branch from 5c86b34 to 5efe440 Compare October 17, 2023 12:53
@bt4R9 bt4R9 marked this pull request as ready for review October 18, 2023 13:36
@bt4R9 bt4R9 requested a review from imsitnikov October 18, 2023 13:36
src/const/common.ts Outdated Show resolved Hide resolved
src/routes.ts Outdated Show resolved Hide resolved
@bt4R9 bt4R9 force-pushed the feature-copy-entries-to-workbook branch from c68b322 to 6a8c6f8 Compare October 23, 2023 07:58
@bt4R9 bt4R9 requested review from imsitnikov and jhoncool October 23, 2023 09:04
const result = await copyEntriesToWorkbook(
{ctx: req.ctx},
{
entryIds: body.ids,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

body.ids -> body.entryIds would be better, in other parts we use this naming

@bt4R9 bt4R9 force-pushed the feature-copy-entries-to-workbook branch from e66646f to 1253048 Compare November 1, 2023 10:13
@bt4R9 bt4R9 merged commit d7f4d09 into main Nov 1, 2023
3 checks passed
@bt4R9 bt4R9 deleted the feature-copy-entries-to-workbook branch November 1, 2023 11:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants