A start at compatibility for python 3.5 - PySide and Qt4. #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fixed some bad exception catches (for py 3+)
Fixed setup.py to check for pyside and pyqt4 and only fail if neither can be imported.
Some times .csv files may have the .txt or other file extentions despite thier encoding.
This reverts commit bddab1f.
# Conflicts: # pandasqt/views/CSVDialogs.py
Trying to fix errors that came up when running test_dataTableView.py
I haven't used the 2to3 command extensively. Hopefully this dosen't break everything.
Ran 2to3 everything. Let's see what happens.
Added small a functional example.
Python 3.x ready.
Merging file path update
added 6 commits
December 6, 2016 09:03
README.md updates and Travis file added.
adding windows tests to travis
I must have overlooked this at some point. Everything seems okay now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The CSVDialog will import .txt and .xlsx files using the superReadFile method added to the utilities file. Pandas is really good at throwing errors if you get the encoding wrong, so if you rely on that you can try a few different codecs and the user experience is a lot nicer when importing the file getting immediate preview results (with header).