Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: namespace Datamweb\ShieldOAuth\Libraries\GoogleOAuth class line 100 uses an incorrect property for the user's first name. #177

Open
AaronMk44 opened this issue Oct 14, 2024 · 1 comment
Labels
bug Something isn't working

Comments

@AaronMk44
Copy link

AaronMk44 commented Oct 14, 2024

PHP Version

8.1

CodeIgniter4 Version

4.5.5

Shield Version

1.1

Shield OAuth Version?

dev-develop

Which operating systems have you tested for this bug?

Windows

Which server did you use?

apache

Database

MariaDB

Did you add customize OAuth?

Google

What happened?

The first name column in the database table had the user's first and last name combined. After checking the data coming back from the Google OAuth system. It returns the following field: name, given_name, family_name, .... It seems the library (this) uses the 'name' field instead of 'given_name.'

Steps to Reproduce

Integrate Google Sign in into a blank CodeIgniter 4 project using this library. Follow the docs

Expected Output

The first name must only have the first name and the last name must only have the last name. This is in connection with the users table.

Anything else?

Nothing

@AaronMk44 AaronMk44 added the bug Something isn't working label Oct 14, 2024
@AaronMk44 AaronMk44 changed the title Bug: namespace Datamweb\ShieldOAuth\Libraries\GoogleOAuth class line 100 uses an incorrect property. Bug: namespace Datamweb\ShieldOAuth\Libraries\GoogleOAuth class line 100 uses an incorrect property for the user's first name. Oct 14, 2024
@datamweb
Copy link
Owner

Maybe related to #111

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants