Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: change message when empty #55

Merged
merged 9 commits into from
Jan 20, 2025
Merged

fix: change message when empty #55

Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
6ff445a
fix: removed line of code that caused unwanted return
Simun17 Dec 20, 2024
c551522
refactor: changed message when there are no registered schemas
Simun17 Dec 20, 2024
4b191b2
fix: added avro error reason to message header (#41)
Simun17 Jan 7, 2025
8d51574
feat: default header schema (#39)
Simun17 Jan 7, 2025
3d7f59e
Merge branch 'develop' into ref/change-message-when-empty
Simun17 Jan 7, 2025
d99a99b
changed the message
Simun17 Jan 7, 2025
86c6390
change code
Simun17 Jan 8, 2025
8b5bfc2
fix: changed code from 204 to 200 when SR is empty
Simun17 Jan 20, 2025
666cee2
Merge branch 'main' into ref/change-message-when-empty
Simun17 Jan 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions registry/server/handler.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -357,9 +357,10 @@ func (h Handler) GetSchemas(w http.ResponseWriter, _ *http.Request) {
schemas, err := h.Service.GetSchemas()
if err != nil {
if errors.Is(err, registry.ErrNotFound) {
body, _ := json.Marshal(report{Message: "No active schemas registered in the Registry"})
writeResponse(w, responseBodyAndCode{
Body: serializeErrorMessage("No active schemas registered in the Registry"),
Code: http.StatusNoContent,
Body: body,
Code: http.StatusOK,
})
return
}
Expand Down
Loading