Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UFAL/PY-resourcepolicy old 18320 != new 15435 #83

Closed
milanmajchrak opened this issue Aug 10, 2023 · 6 comments · Fixed by #102
Closed

UFAL/PY-resourcepolicy old 18320 != new 15435 #83

milanmajchrak opened this issue Aug 10, 2023 · 6 comments · Fixed by #102
Assignees
Labels
bug Something isn't working ufal

Comments

@milanmajchrak
Copy link
Collaborator

No description provided.

@milanmajchrak milanmajchrak added bug Something isn't working ufal labels Aug 10, 2023
@MajoBerger
Copy link
Contributor

In clarin DSpace for each item there are several resource policies, that are not necessary, since in DSpace 7.5 those policies are hierarchical.

@Paurikova2
Copy link
Collaborator

Notes:
Where does the resourcepolisy create?

  1. Community
    create community (CommunityServiceImpl [120] -> Anonymous - READ)
    create community administrator -> delete default policy and create new
    Result: 9 new added policy -> 8 anonymous, 1 admin group
    Notes: Praha data contains 7 anonymous and 2 admin groups (44, 57), but if the community has admin group, it should be in its attribute admin. And in Praha data, there is only one community with admin attribute filled: community with id 44. That's the reason why there is incompatibility between resourcepolicy in their data and our data connected with community.

2 Collection
create collection (CollectionServiceImpl [139] -> Anonymous - READ, DEFAULT_ITEM_READ, DEFAULT_BITSTREAM_READ
create workflowrole -> collection workflow_step_2 ->XmlWorkflowServiceImpl [188] -> ADD
- > submitter -> CollectionServiceImpl [509] -> ADD
coll2group -> CollectionServiceImpl [938] -> remove existing privileges from anonymous group and add DEFAULT_BITSTREAM_READ and DEFAULT_ITEM_READ -> WORKS

Collections: missing 6

  1. Items
    create - WorkspaceItemServiceImpl [124] -> READ, WRITE, ADD, REMOVE, DELETE (type TYPE_SUBMISSION)
    grantGroupAllItemPolicies - XmlServiceImpl -> calling from importWorkflowItem -> READ, WRITE, DELETE, ADD, REMOVE

@MajoBerger
Copy link
Contributor

MajoBerger commented Oct 3, 2023

There are differences between some resource policies. As named in import Statistics:

expected = number of rows in old (5.2) database
imported = number of rows in new (7.5) database
duplicated = policy DEFAULT_READ from old DSpace is now divided into DEFAULT_BITSTREAM_READ and DEFAULT_ITEM_READ. Therefore for each one such resource policy in old DSpace, there are two resource policies in new DSpace.
unimported = amongst other things, most importantly this number includes such resource policies from old dspace, that related to an item no longer existing. Therefore REST API did not allow importing such resource policy. There are also errors counted in this number.

@MajoBerger
Copy link
Contributor

Should be checked here

#105

@Paurikova2
Copy link
Collaborator

#105

@milanmajchrak
Copy link
Collaborator Author

It is developed here: #101

@milanmajchrak milanmajchrak linked a pull request Oct 19, 2023 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working ufal
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants