Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Not to use double interpolation #91

Open
roman-dubrovsky opened this issue Aug 14, 2019 · 5 comments
Open

Not to use double interpolation #91

roman-dubrovsky opened this issue Aug 14, 2019 · 5 comments
Assignees
@roman-dubrovsky
Labels
blocked feature request New feature or request library issue issue has been created in rubocop library or just in progress and waiting for approval postponed Not valuable for now

Comments

@roman-dubrovsky
Copy link
Contributor

Is your feature request related to a problem? Please describe.
Avoid using double interpolation in the one string

Your thoughts?

Additional context.
Example

"/campaigns/#{@workflow.persisted? ? "update_step/#{@workflow.campaign_id}.json" : "create_step/#{@campaign.id}.json"}"
@roman-dubrovsky roman-dubrovsky added feature request New feature or request duplicate postponed Not valuable for now and removed duplicate labels Aug 14, 2019
@AleksSenkou
Copy link

Love it

@roman-dubrovsky roman-dubrovsky removed the postponed Not valuable for now label Oct 24, 2019
@roman-dubrovsky roman-dubrovsky modified the milestones: 0.5.0, 0.6.0 Oct 24, 2019
@roman-dubrovsky roman-dubrovsky added the good first issue Easy task, suitable for newcomers to the project label Oct 26, 2019
@roman-dubrovsky
Copy link
Contributor Author

Added issue rubocop/rubocop#7480

@roman-dubrovsky roman-dubrovsky self-assigned this Nov 4, 2019
@roman-dubrovsky roman-dubrovsky added blocked and removed good first issue Easy task, suitable for newcomers to the project labels Nov 4, 2019
@roman-dubrovsky roman-dubrovsky modified the milestones: 0.6.0, 0.7.0 Nov 6, 2019
@roman-dubrovsky roman-dubrovsky modified the milestones: 0.7.0, 0.8.0 Jan 27, 2020
@lazycoder9
Copy link
Contributor

@roman-dubrovsky we can start by implementing our custom cop in this repo, WDYT?

@roman-dubrovsky
Copy link
Contributor Author

yep, I'm going to do it

roman-dubrovsky added a commit that referenced this issue Feb 5, 2020
@roman-dubrovsky
[#91] Add nested interpolation cop
c8f4ebf
@roman-dubrovsky roman-dubrovsky mentioned this issue Feb 5, 2020
Merged
7 tasks
@roman-dubrovsky roman-dubrovsky added the help wanted Extra attention is needed label Feb 6, 2020
@roman-dubrovsky
Copy link
Contributor Author

Made PR to rubocop repo rubocop/rubocop#7714

@roman-dubrovsky roman-dubrovsky removed the help wanted Extra attention is needed label Feb 13, 2020
roman-dubrovsky added a commit that referenced this issue Feb 13, 2020
@roman-dubrovsky
[#91] Add nested interpolation cop (#158)
8fc7f04 
* [#91] Add nested interpolation cop

* Add more tests

* Fix issues from rubocop repo
@roman-dubrovsky roman-dubrovsky added postponed Not valuable for now fixed in new library version the issue has been reported and fixed in library repository but has not been merged or released yet labels Feb 13, 2020
@roman-dubrovsky roman-dubrovsky modified the milestone: 0.8.0 Feb 13, 2020
@roman-dubrovsky roman-dubrovsky modified the milestones: 0.8.0, 0.9.0 Feb 19, 2020
@roman-dubrovsky roman-dubrovsky added library issue issue has been created in rubocop library or just in progress and waiting for approval and removed fixed in new library version the issue has been reported and fixed in library repository but has not been merged or released yet postponed Not valuable for now labels Feb 19, 2020
@roman-dubrovsky roman-dubrovsky modified the milestones: 0.10.0, 0.11.0 Jul 17, 2020
@roman-dubrovsky roman-dubrovsky modified the milestones: 0.11.0, 1.1.0 Nov 7, 2020
@roman-dubrovsky roman-dubrovsky added the postponed Not valuable for now label Nov 10, 2020
@roman-dubrovsky roman-dubrovsky removed this from the 1.1.0 milestone Nov 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@roman-dubrovsky roman-dubrovsky

Labels
blocked feature request New feature or request library issue issue has been created in rubocop library or just in progress and waiting for approval postponed Not valuable for now
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@AleksSenkou @roman-dubrovsky @lazycoder9