Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

migration tool should only put non-default values in the generated values file #118

Open
pgier opened this issue Jul 31, 2023 · 2 comments

Comments

@pgier
Copy link
Collaborator

pgier commented Jul 31, 2023

To keep the generated values more concise and allow for easier review, the migration tool should only print values which override the defaults.

An alternative might be a tool to remove all default values from an existing values file. Then you could take the output of the current migration tool and run it through the cleanup/minimize tool.

@nicoloboschi
Copy link
Contributor

This is already done partially.
Could you list which values did you see ?

@pgier
Copy link
Collaborator Author

pgier commented Aug 16, 2023

Looking at the generated values.yaml file, there are lots of values included which match the default settings. Here are a few examples:

kaap:
  cluster:
    spec:
      global:
        dnsConfig:
          options:
          - name: ndots
            value: '4'
        kubernetesClusterDomain: cluster.local
        tls:
          brokerResourceSets: {
            }
          proxyResourceSets: {
            }
      zookeeper:
        nodeSelectors: {
          }
        tolerations: [
          ]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants