Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Client connection can be closed before proxy returns protocol error #69

Closed
joao-r-reis opened this issue Oct 19, 2022 · 0 comments · Fixed by #67
Closed

Client connection can be closed before proxy returns protocol error #69

joao-r-reis opened this issue Oct 19, 2022 · 0 comments · Fixed by #67
Assignees
@joao-r-reis
Labels
bug Something isn't working
Milestone
2.1.0

Comments

@joao-r-reis
Copy link
Collaborator

joao-r-reis commented Oct 19, 2022 •
edited by sync-by-unito bot
Loading

When a protocol error happens (as part of protocol version negotiation or not), the proxy invokes the shutdown mechanism for that connection after sending the response to the write queue but due to #68 the client may see the connection closed without the protocol error actually being sent.

Due to this, the proxy should at least not shutdown the connection when a protocol error happens while #68 is not addressed.

┆Issue is synchronized with this Jira Task by Unito
┆friendlyId: ZDM-411
joao-r-reis added a commit that referenced this issue Oct 19, 2022
@joao-r-reis
fix #69
215ab16
@joao-r-reis joao-r-reis mentioned this issue Oct 19, 2022
Merged
@joao-r-reis joao-r-reis self-assigned this Oct 19, 2022
@joao-r-reis joao-r-reis added the bug Something isn't working label Oct 19, 2022
joao-r-reis added a commit that referenced this issue Oct 20, 2022
@joao-r-reis
Fix flaky tests and fix #69 (#67)
ee0181b 
Fix #69 
Fix more flaky tests
@joao-r-reis joao-r-reis added this to the TBD milestone Oct 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@joao-r-reis joao-r-reis

Labels
bug Something isn't working
Projects
None yet
Milestone
2.1.0
Development

Successfully merging a pull request may close this issue.

Fix flaky tests and fix #69 datastax/zdm-proxy
1 participant
@joao-r-reis