Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove all 'any' and || types #87

Open
keithfrazier98 opened this issue Feb 17, 2022 · 1 comment
Open

Remove all 'any' and || types #87

keithfrazier98 opened this issue Feb 17, 2022 · 1 comment
Labels

Comments

@keithfrazier98
Copy link
Contributor

keithfrazier98 commented Feb 17, 2022

Currently, an issue stemming from issue #86, there are multiple occurrences of 'any' being used in unsafe/subpar ways throughout the dapp. Once #86 is fixed, all 'any' types should be converted to definite types, as well as any occurrence of a variable being used and will default to an empty string if the variable is undefined. There are numerous places that look like this someVar || "" this should be avoided and further conditional checks should be implemented to revise how falsy values are handled.

@0xaki
Copy link

0xaki commented Feb 25, 2022

dapp repo issues

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants