Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kustomize resource (non-custom) definitions #99

Closed
wyardley opened this issue Jan 13, 2023 · 3 comments
Closed

kustomize resource (non-custom) definitions #99

wyardley opened this issue Jan 13, 2023 · 3 comments

Comments

@wyardley
Copy link
Contributor

I am guessing this project isn't the right place to host kustomize.config.k8s.io resource definitions, since they're builtin, and not custom. However, they're also not hosted on the project we typically use that has the main schemas (see context in yannh/kubernetes-json-schema#13).

Is it reasonable to assume that since they're not "custom", they shouldn't be added here?

@wyardley
Copy link
Contributor Author

note: these are different from the flux kustomize types which are already included here
https://fluxcd.io/flux/faq/#are-there-two-kustomization-types

@eyarz
Copy link
Member

eyarz commented Jan 15, 2023

The main reason why NOT to host the schema in this project (or yannh/kubernetes-json-schema) is that it will just not work 😅

Kubconform relies on the kind property to match the manifest with the right schema.
Kustomize manifests can be valid also without this property, they are "just" yaml files...

You have this open-source project that is hosting the kustomize schema:
https://json.schemastore.org/kustomization.json

@wyardley
Copy link
Contributor Author

Thanks! Yes, I tried using the schema above earlier, and it seemed to work (I believe ours do have the kind property defined), but it wasn’t clear which version(s) it referred to.

Thanks for merging my PRs, btw!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants